linux-kernel - Re: linux-next: build warning after merge of the reset tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad2a190a1f93edb787478ed3433b154b9753f7c8.camel@pengutronix.de>
Date: Fri, 25 Oct 2024 16:46:54 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Rob Herring <robh@...nel.org>, Herve Codina <herve.codina@...tlin.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>, Linux Kernel Mailing List
	 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
	 <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the reset tree

On Fr, 2024-10-25 at 08:44 -0500, Rob Herring wrote:
> On Fri, Oct 25, 2024 at 1:28 AM Herve Codina <herve.codina@...tlin.com> wrote:
> > 
> > Hi all,
> > 
> > On Fri, 25 Oct 2024 11:09:19 +1100
> > Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> > 
> > > Hi all,
> > > 
> > > After merging the reset tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@..._overlay__/pci-ep-bus@...ic@...c0120: Missing interrupt-parent
> > > 
> > > Introduced by commit
> > > 
> > >   185686beb464 ("misc: Add support for LAN966x PCI device")
> > > 
> > 
> > This warning is normal.
> > interrupt-parent is not present in the oic node. This was discussed in
> > https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/
> 
> We can't have warnings especially in things outside of arch/. Doesn't
> matter why.
> 
> The choices to fix are:
> 
> - Override DTC_FLAGS in drivers/misc/. You can set DTC_FLAGS_lan966x_pci
> 
> - Disable the check in dtc for overlays. We've done this for other cases.
> 
> - Add enough info into the overlay to avoid the warnings. This might
> mean the overlay has to be applied up one node level. It is
> duplicating a few things which are in the base tree. This is my
> preference because it makes the overlay stand on its own. We'll have
> the same issue with dtschema checks too if we don't do this.

I see four more warnings that look like false positives to me:

drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@..._overlay__/pci-ep-bus@...pu_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@..._overlay__/pci-ep-bus@...dr_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@..._overlay__/pci-ep-bus@...ys_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@..._overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property

Setting

DTC_FLAGS_lan966x_pci := -Wno-interrupts_property -Wno-simple_bus_reg -Wno-avoid_unnecessary_addr_size

silences them all.

regards
Philipp