linux-kernel - Re: [PATCH v2 3/4] dma-mapping: Use trace_dma_alloc for dma_alloc* instead of using trace_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241024221955.2fd9356e@rorschach.local.home>
Date: Thu, 24 Oct 2024 22:19:55 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Christoph Hellwig <hch@....de>, iommu@...ts.linux.dev, Robin Murphy
 <robin.murphy@....com>, linux-trace-kernel@...r.kernel.org, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Masami Hiramatsu
 <mhiramat@...nel.org>, Marek Szyprowski <m.szyprowski@...sung.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] dma-mapping: Use trace_dma_alloc for dma_alloc*
 instead of using trace_dma_map

On Fri, 18 Oct 2024 11:00:36 -0400
Sean Anderson <sean.anderson@...ux.dev> wrote:

> +	TP_printk("%s dir=%s dma_addr=%llx size=%zu phys_addrs=%s flags=%s attrs=%s",
> +		__get_str(device),
> +		decode_dma_data_direction(__entry->dir),
> +		__entry->dma_addr,
> +		__entry->size,
> +		__print_array(__get_dynamic_array(phys_addrs),
> +			      __get_dynamic_array_len(phys_addrs) /
> +				sizeof(u64), sizeof(u64)),
> +		show_gfp_flags(__entry->flags),
> +		decode_dma_attrs(__entry->attrs))

From a tracing perspective, everything in the patch set looks good.
Just a heads up that the above __print_array() should be changed after
6.13 is out to use __print_dynamic_array().

  https://lore.kernel.org/linux-trace-kernel/20241022194158.110073-3-avadhut.naik@amd.com/

For the series:

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve