linux-kernel - Re: [PATCH] pinctrl: qcom: spmi: fix debugfs drive strength

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c153d278-7b61-4feb-a749-43226357acc3@gmail.com>
Date: Fri, 25 Oct 2024 18:49:38 +0200
From: Konrad Dybcio <konradybcio@...il.com>
To: Johan Hovold <johan+linaro@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Anjelique Melendez <quic_amelende@...cinc.com>, stable@...r.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: spmi: fix debugfs drive strength

On 25.10.2024 2:16 PM, Johan Hovold wrote:
> Commit 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength
> mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio
> driver which had the 'low' and 'high' drive strength settings switched
> but failed to update the debugfs interface which still gets this wrong.
> 
> Fix the debugfs code so that the exported values match the hardware
> settings.
> 
> Note that this probably means that most devicetrees that try to describe
> the firmware settings got this wrong if the settings were derived from
> debugfs. Before the above mentioned commit the settings would have
> actually matched the firmware settings even if they were described
> incorrectly, but now they are inverted.
> 
> Fixes: 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping")
> Fixes: eadff3024472 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver")
> Cc: Anjelique Melendez <quic_amelende@...cinc.com>
> Cc: stable@...r.kernel.org	# 3.19
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad