linux-kernel - Re: [PATCH v3 3/3] lockdep: document MAX_LOCKDEP_CHAIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ed443myn.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date: Fri, 25 Oct 2024 11:01:20 +0800
From: "Huang, Ying" <ying.huang@...el.com>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Boqun Feng <boqun.feng@...il.com>,  Andrew Morton
 <akpm@...ux-foundation.org>,  Peter Zijlstra <peterz@...radead.org>,  Ingo
 Molnar <mingo@...hat.com>,  Will Deacon <will@...nel.org>,
  linux-kernel@...r.kernel.org,  kernel-team@...roid.com,  Waiman Long
 <longman@...hat.com>,  "J. R. Okajima" <hooanon05g@...il.com>
Subject: Re: [PATCH v3 3/3] lockdep: document MAX_LOCKDEP_CHAIN_HLOCKS
 calculation

Carlos Llamas <cmllamas@...gle.com> writes:

> Define a macro AVG_LOCKDEP_CHAIN_DEPTH to document the magic number '5'
> used in the calculation of MAX_LOCKDEP_CHAIN_HLOCKS. The number
> represents the estimated average depth (number of locks held) of a lock
> chain. The calculation of MAX_LOCKDEP_CHAIN_HLOCKS was first added in
> commit 443cd507ce7f ("lockdep: add lock_class information to lock_chain
> and output it").
>
> Suggested-by: Waiman Long <longman@...hat.com>
> Cc: Huang Ying <ying.huang@...el.com>
> Cc: J. R. Okajima <hooanon05g@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Boqun Feng <boqun.feng@...il.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Will Deacon <will@...nel.org>
> Acked-by: Waiman Long <longman@...hat.com>
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

LGTM, Thanks!  Feel free to add

Acked-by: "Huang, Ying" <ying.huang@...el.com>

in the future versions.

> ---
> v3: collect tags
> v2: switched the comment for a macro as suggested by Waiman Long.
>
>  kernel/locking/lockdep_internals.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep_internals.h b/kernel/locking/lockdep_internals.h
> index bbe9000260d0..20f9ef58d3d0 100644
> --- a/kernel/locking/lockdep_internals.h
> +++ b/kernel/locking/lockdep_internals.h
> @@ -119,7 +119,8 @@ static const unsigned long LOCKF_USED_IN_IRQ_READ =
>  
>  #define MAX_LOCKDEP_CHAINS	(1UL << MAX_LOCKDEP_CHAINS_BITS)
>  
> -#define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
> +#define AVG_LOCKDEP_CHAIN_DEPTH		5
> +#define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS * AVG_LOCKDEP_CHAIN_DEPTH)
>  
>  extern struct lock_chain lock_chains[];