linux-kernel - Re: [PATCH v2] bcachefs: fix null-ptr-deref in have

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bshr5tserk5lqpfs7xpjz6k3hfptcmoky7z2mhq5mrkbux3bh7@gdsyl2pbmlxx>
Date: Fri, 25 Oct 2024 13:17:35 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Alan Huang <mmpgouride@...il.com>
Cc: Jeongjun Park <aha310510@...il.com>, linux-bcachefs@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>, syzbot+b468b9fef56949c3b528@...kaller.appspotmail.com
Subject: Re: [PATCH v2] bcachefs: fix null-ptr-deref in have_stripes()

On Sat, Oct 26, 2024 at 01:05:50AM +0800, Alan Huang wrote:
> On Oct 26, 2024, at 00:54, Kent Overstreet <kent.overstreet@...ux.dev> wrote:
> > 
> > On Fri, Oct 25, 2024 at 08:56:18PM +0900, Jeongjun Park wrote:
> >> c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference
> >> occurs, so you need to add code to check the variable.
> >> 
> >> Reported-by: syzbot+b468b9fef56949c3b528@...kaller.appspotmail.com
> >> Fixes: 7773df19c35f ("bcachefs: metadata version bucket_stripe_sectors")
> >> Signed-off-by: Jeongjun Park <aha310510@...il.com>
> > 
> > This looks identical to the v1? It's already in my testing branch
> 
> This version fix the “Fixes" tag, the original one is:
> 
> "Fixes: ("bcachefs: metadata version bucket_stripe_sectors”)"

thanks