linux-kernel - Re: [GIT PULL] fbdev late fixes for v6.12-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjKouRizUF97ZABtCmijjKR+sAOmWA4uiYhhSOwhxCT3w@mail.gmail.com>
Date: Fri, 25 Oct 2024 11:31:58 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Helge Deller <deller@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org
Subject: Re: [GIT PULL] fbdev late fixes for v6.12-rc5

On Fri, 25 Oct 2024 at 09:04, Helge Deller <deller@...nel.org> wrote:
>
> It's mostly about build warning fixes with cornercase CONFIG settings
> and one big patch which removes the now unused da8xx fbdev driver.

So I pulled this, but only later noticed that some of the Kconfig
"fixes" are anything but.

At least commit 447794e44744 ("fbdev: sstfb: Make CONFIG_FB_DEVICE
optional") is not fixing anything, and very questionable.

For no reason at all does it seem to enable 30-year old hardware in a
new configuration.

There were no build issues before, the build issues that existed were
*introduced* by broken early versions of this patch.

Does anybody even *have* that hardware? Why were those pointless changes made?

Sure, the Voodoo1 was the bomb back in 1996 if you wanted to run
hw-accelerated Quake, but in 2024, this change should have had more
explanation for why anybody would care about the CONFIG_FB_DEVICE
dependency.

And in no case should it have been marked as a "fix".

                 Linus