[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org>
Date: Fri, 25 Oct 2024 15:45:27 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc: Matthew Wilcox <willy@...radead.org>, hughd@...gle.com,
david@...hat.com, wangkefeng.wang@...wei.com, shy828301@...il.com,
dhowells@...hat.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: shmem: fallback to page size splice if large folio
has poisoned subpages
On Fri, 25 Oct 2024 11:41:28 +0800 Baolin Wang <baolin.wang@...ux.alibaba.com> wrote:
>
>
> On 2024/10/25 11:31, Matthew Wilcox wrote:
> > On Fri, Oct 25, 2024 at 11:26:39AM +0800, Baolin Wang wrote:
> >> The tmpfs has already supported the PMD-sized large folios, and splice()
> >> can not read any subpages if the large folio has a poisoned subpage,
> >> which is not good as we discussed in previous mail[1].
> >
> > folios do not have subpages. folios have pages. do not use the term
> > "subpage" anywhere. ever.
>
> OK. This is my previous habit of naming it. Will change 'subpages' to
> 'pages' for folios.
While at it, please try to avoid depending upon references to previous
email discussions. The links may be bad 10 years from now, and it's
laborious for readers to trawl through the online discussion archives
to extract the information they need.
Including the link is fine, and potentially useful. But please also
include the relevant information right here in the changelog.
Powered by blists - more mailing lists