linux-kernel - Re: [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61308a22-f63d-403f-bed7-c082bf716bce@oldschoolsolutions.biz>
Date: Fri, 25 Oct 2024 07:35:44 +0200
From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Merck Hung <merckhung@...il.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt
 definition for WDK2023


On 18.10.24 16:38, Konrad Dybcio wrote:
> On 13.10.2024 1:54 PM, Jens Glathe via B4 Relay wrote:
>> From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>>
>> Device tree for the Microsoft Windows Dev Kit 2023. This work
>> is based on the initial work of Merck Hung <merckhung@...il.com>.
>>
>> The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp.
>> Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/
> [...]
>
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&wcd_default>;
> property-n
> property-names
>
> (all throughout the file)
>
> [...]
>
>> +	pmic-glink {
>> +		compatible = "qcom,sc8280xp-pmic-glink", "qcom,pmic-glink";
>> +
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +		orientation-gpios = <&tlmm 166 GPIO_ACTIVE_HIGH>,
>> +				    <&tlmm 49 GPIO_ACTIVE_HIGH>;
>> +
>> +		connector@0 {
> Could you add a comment describing which connector is which (see e.g.
> x1e80100-microsoft-romulus.dtsi)
>
> [...]
>
>> +&gpu {
>> +	status = "okay";
>> +
>> +	zap-shader {
>> +		memory-region = <&gpu_mem>;
>> +		firmware-name = "qcom/sc8280xp/MICROSOFT/blackrock/qcdxkmsuc8280.mbn";
> "microsoft" lowercase would be consistent with other DTs in arm64/qcom
Hmm what about Lenovo X13s. I'll change it to lower case.
>
> [...]
>
>> +&sound {
>> +	compatible = "qcom,sc8280xp-sndcard";
>> +	model = "MICROSOFT/blackrock";
>> +	audio-routing =
>> +		"SpkrLeft IN", "WSA_SPK1 OUT",
>> +		"SpkrRight IN", "WSA_SPK2 OUT",
>> +		"IN1_HPHL", "HPHL_OUT",
>> +		"IN2_HPHR", "HPHR_OUT",
>> +		"AMIC2", "MIC BIAS2",
>> +		"VA DMIC0", "MIC BIAS1",
>> +		"VA DMIC1", "MIC BIAS1",
>> +		"VA DMIC2", "MIC BIAS3",
>> +		"VA DMIC0", "VA MIC BIAS1",
>> +		"VA DMIC1", "VA MIC BIAS1",
>> +		"VA DMIC2", "VA MIC BIAS3",
>> +		"TX SWR_ADC1", "ADC2_OUTPUT";
>> +
>> +	wcd-playback-dai-link {
>> +		link-name = "WCD Playback";
>> +		cpu {
> Please add a newline between the property and the subnodes
>
> Konrad
>
Will do a v4 now with all the new input.

- Jens