linux-kernel - [PATCH] goldfish: Fix unused const variable 'goldfish_pipe_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025074129.1920707-1-zengheng4@huawei.com>
Date: Fri, 25 Oct 2024 15:41:29 +0800
From: Zeng Heng <zengheng4@...wei.com>
To: <jia-cheng.hu@...el.com>, <gregkh@...uxfoundation.org>,
	<quic_jjohnson@...cinc.com>, <u.kleine-koenig@...gutronix.de>,
	<jinqian@...roid.com>, <alan@...ux.intel.com>
CC: <linux-kernel@...r.kernel.org>, <bobo.shaobowang@...wei.com>
Subject: [PATCH] goldfish: Fix unused const variable 'goldfish_pipe_acpi_match'

Fix the following compilation warning:

drivers/platform/goldfish/goldfish_pipe.c:925:36: warning:
‘goldfish_pipe_acpi_match’ defined but not used
[-Wunused-const-variable=]
  925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = {

Only define the const variable when the CONFIG_ACPI is enabled.

Fixes: d62f324b0ac8 ("goldfish: Enable ACPI-based enumeration for android pipe")
Signed-off-by: Zeng Heng <zengheng4@...wei.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index c2aab0cfab33..aeabacba3760 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -922,11 +922,13 @@ static void goldfish_pipe_remove(struct platform_device *pdev)
 	goldfish_pipe_device_deinit(pdev, dev);
 }
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
 	{ "GFSH0003", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, goldfish_pipe_acpi_match);
+#endif
 
 static const struct of_device_id goldfish_pipe_of_match[] = {
 	{ .compatible = "google,android-pipe", },
-- 
2.25.1