linux-kernel - Re: [PATCH] sched: Fix compile warning about variable 'uclamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025073213.GE36494@noisy.programming.kicks-ass.net>
Date: Fri, 25 Oct 2024 09:32:13 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Qi Xi <xiqi2@...wei.com>
Cc: kernel@...neuler.org, bobo.shaobowang@...wei.com, mingo@...hat.com,
	juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, vschneid@...hat.com, patrick.bellasi@....com,
	mkoutny@...e.com, tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Fix compile warning about variable 'uclamp_mutex'

On Fri, Oct 25, 2024 at 11:47:40AM +0800, Qi Xi wrote:
> When build with CONFIG_UCLAMP_TASK && !CONFIG_UCLAMP_TASK_GROUP,
> the variable 'uclamp_mutex' is defined but not used:
> 
> kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used [-Wunused-variable]
>     1361 | static DEFINE_MUTEX(uclamp_mutex);
> 
> Fix this by only defining the variable uclamp_mutex when the
> CONFIG_UCLAMP_TASK_GROUP is enabled.

sigh.. I hate our CONFIG space :/

Perhaps add __maybe_unused like the other variables it sits right next
to instead of adding yet more #ifdef crud?