linux-kernel - Re: [PATCH -tip] cleanup: Remove address space of returned pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFULd4bBaFWVZv=hERmHExn7ToJbJ6a+VCtZPQ3FvbPO=5EJCg@mail.gmail.com>
Date: Fri, 25 Oct 2024 09:35:29 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH -tip] cleanup: Remove address space of returned pointer

On Fri, Oct 18, 2024 at 1:23 PM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Mon, Aug 19, 2024 at 09:41:15AM +0200, Uros Bizjak wrote:
> > Guard functions in local_lock.h are defined using DEFINE_GUARD() and
> > DEFINE_LOCK_GUARD_1() macros having lock type defined as pointer in
> > the percpu address space. The functions, defined by these macros
> > return value in generic address space, causing:
> >
> > cleanup.h:157:18: error: return from pointer to non-enclosed address space
> >
> > and
> >
> > cleanup.h:214:18: error: return from pointer to non-enclosed address space
> >
> > when strict percpu checks are enabled.
> >
> > Add explicit casts to remove address space of the returned pointer.
> >
> > Found by GCC's named address space checks.
> >
> > Fixes: e4ab322fbaaa ("cleanup: Add conditional guard support")
> > Signed-off-by: Uros Bizjak <ubizjak@...il.com>
>
> Thanks!
>
> Now lives in queue locking/core, and barring robot screams will make its
> way into tip.

I noticed that the patch was removed from the queue. Was there
something wrong with it?

Uros.