linux-kernel - Re: [PATCH vhost 1/2] vdpa/mlx5: Fix PA offset with unaligned starting iotlb map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEsmp3q=TQr7qUhdqtAw4ALLXYagn=BKZegks-=CAsF_XQ@mail.gmail.com>
Date: Fri, 25 Oct 2024 16:42:07 +0800
From: Jason Wang <jasowang@...hat.com>
To: Dragos Tatulea <dtatulea@...dia.com>
Cc: "Michael S . Tsirkin" <mst@...hat.com>, virtualization@...ts.linux.dev, 
	Si-Wei Liu <si-wei.liu@...cle.com>, Eugenio Perez Martin <eperezma@...hat.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Gal Pressman <gal@...dia.com>, 
	Parav Pandit <parav@...dia.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, stable@...r.kernel.org
Subject: Re: [PATCH vhost 1/2] vdpa/mlx5: Fix PA offset with unaligned
 starting iotlb map

On Mon, Oct 21, 2024 at 9:41 PM Dragos Tatulea <dtatulea@...dia.com> wrote:
>
> From: Si-Wei Liu <si-wei.liu@...cle.com>
>
> When calculating the physical address range based on the iotlb and mr
> [start,end) ranges, the offset of mr->start relative to map->start
> is not taken into account. This leads to some incorrect and duplicate
> mappings.
>
> For the case when mr->start < map->start the code is already correct:
> the range in [mr->start, map->start) was handled by a different
> iteration.
>
> Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
> Cc: stable@...r.kernel.org
> Signed-off-by: Si-Wei Liu <si-wei.liu@...cle.com>
> Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> ---

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks