linux-kernel - Re: [PATCH v6 7/7] leds: max77705: Add LEDs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025085523.GC10824@google.com>
Date: Fri, 25 Oct 2024 09:55:23 +0100
From: Lee Jones <lee@...nel.org>
To: Dzmitry Sankouski <dsankouski@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Pavel Machek <pavel@....cz>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-input@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v6 7/7] leds: max77705: Add LEDs support

On Tue, 22 Oct 2024, Dzmitry Sankouski wrote:

> (...)
> > >  drivers/leds/leds-max77705.c | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Lol!  How big is your terminal? :)
> >
> 
> Dunno actually, this was generated by b4
> 
> (...)
> 
> 
> > No C++ comments please.
> >
> 
> This conflicts with https://patchwork.kernel.org/comment/25898728/

a) That's just for the header.
b) That's a different subsystem and Mark's choice.

> > > +             ret = regmap_update_bits(led->regmap,
> > > +                                     MAX77705_RGBLED_REG_LEDEN,
> > > +                                     MAX77705_LED_EN_MASK << led->en_shift, 0);
> > > +             max77705_rgb_blink(cdev, &blink_default, &blink_default);
> > > +     } else {
> > > +             // Set current
> > > +             ret = regmap_write(led->regmap,
> > > +                                led->reg_brightness, brightness);
> >
> > Line wrap at 100-chars.
> >
> 
> From coding-style.rst:
> `The preferred limit on the length of a single line is 80 columns.`
> I only exceed 80 chars, when there's no good wrapping.

a) This is old guidance
b) A lot of your lines already break the 80-char rule.

-- 
Lee Jones [李琼斯]