linux-kernel - Re: [PATCH v3] pwm: imx-tpm: Use correct MODULO value for EPWM mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bj7bgcwkesq3ixhkqveduid2uaieiq2dfu3u7yq7wxemkde2j2@yejpwvdqwpah>
Date: Fri, 25 Oct 2024 11:51:24 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Erik Schumacher <erik.schumacher@...s-sensing.com>
Cc: "kernel@...gutronix.de" <kernel@...gutronix.de>, 
	"thierry.reding@...il.com" <thierry.reding@...il.com>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, 
	"festevam@...il.com" <festevam@...il.com>, "shawnguo@...nel.org" <shawnguo@...nel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>, 
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>
Subject: Re: [PATCH v3] pwm: imx-tpm: Use correct MODULO value for EPWM mode

Hello,

On Fri, Oct 25, 2024 at 08:37:00AM +0000, Erik Schumacher wrote:
> The modulo register defines the period of the edge-aligned PWM mode
> (which is the only mode implemented). The reference manual states:
> "The EPWM period is determined by (MOD + 0001h) ..." So the value that
> is written to the MOD register must therefore be one less than the
> calculated period length. Return -EINVAL if the calculated length is
> already zero.
> A correct MODULO value is particularly relevant if the PWM has to output
> a high frequency due to a low period value.
> 
> Fixes: 738a1cfec2ed ("pwm: Add i.MX TPM PWM driver support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Erik Schumacher <erik.schumacher@...s-sensing.com>

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/fixes

I let it sit there for a few days to get some coverage in next and then
intend to send it to Linus for mainline inclusion ~ mid of next week.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)