linux-kernel - Re: [PATCH v2 11/12] arm64: dts: exynos: Add Exynos9810 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddc66610-018d-4c64-9a26-af592094d5d2@kernel.org>
Date: Fri, 25 Oct 2024 14:43:35 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Markuss Broks <markuss.broks@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Linus Walleij <linus.walleij@...aro.org>, Tomasz Figa
 <tomasz.figa@...il.com>, Will Deacon <will@...nel.org>,
 Mark Rutland <mark.rutland@....com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-gpio@...r.kernel.org, Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
 Maksym Holovach <nergzd@...gzd723.xyz>
Subject: Re: [PATCH v2 11/12] arm64: dts: exynos: Add Exynos9810 SoC support

On 25/10/2024 13:24, Markuss Broks wrote:
> Exynos 9810 is an ARMv8 mobile SoC found in various Samsung devices,
> such as Samsung Galaxy S9 (starlte), S9 Plus (star2lte),
> Note 9 (crownlte) and perhaps others.

...

> +
> +		pinctrl_alive: pinctrl@...50000 {
> +			compatible = "samsung,exynos9810-pinctrl";
> +			reg = <0x14050000 0x1000>;
> +
> +			wakeup-interrupt-controller {
> +				compatible = "samsung,exynos9810-wakeup-eint",
> +						"samsung,exynos850-wakeup-eint",
> +						"samsung,exynos7-wakeup-eint";

Since I expect new version to fix the tags/SoB, please also align above
with opening ".

> +			};
> +		};
> +
> +		pmu_system_controller: system-controller@...60000 {
> +			compatible = "samsung,exynos9810-pmu",
> +				     "samsung,exynos7-pmu", "syscon";
> +			reg = <0x14060000 0x10000>;
> +		};
> +
> +		pinctrl_cmgp: pinctrl@...20000 {
> +			compatible = "samsung,exynos9810-pinctrl";
> +			reg = <0x14220000 0x1000>;
> +
> +			wakeup-interrupt-controller {
> +				compatible = "samsung,exynos9810-wakeup-eint",
> +						"samsung,exynos850-wakeup-eint",
> +						"samsung,exynos7-wakeup-eint";

Ditto here


Best regards,
Krzysztof