linux-kernel - Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025131542.5bfvqtepcefup3hv@mushy>
Date: Fri, 25 Oct 2024 08:15:42 -0500
From: Nishanth Menon <nm@...com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Markus Schneider-Pargmann <msp@...libre.com>,
        "Rafael J . Wysocki"
	<rafael@...nel.org>, Pavel Machek <pavel@....cz>,
        Len Brown
	<len.brown@...el.com>, Vishal Mahaveer <vishalm@...com>,
        Kevin Hilman
	<khilman@...libre.com>, Dhruva Gole <d-gole@...com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value

On 08:49-20241003, Greg Kroah-Hartman wrote:
> On Thu, Oct 03, 2024 at 08:28:12AM +0200, Markus Schneider-Pargmann wrote:
> > On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > > > Export the function dev_pm_qos_read_value(). Most other functions
> > > > mentioned in Documentation/power/pm_qos_interface.rst are already
> > > > exported, so export this one as well.
> > > > 
> > > > This function will be used to read the resume latency in a driver that
> > > > can also be compiled as a module.
> > > 
> > > We don't add exports for no in-kernel users, sorry.  Send this as part
> > > of a series that requires it.
> > 
> > Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
> > can be built as a module. When built as a module it can't use this
> > function if it is not exported.
> 
> So the current kernel build is broken?  If so, please add a "Fixes:" tag
> and say this in the changelog.
> 
> If not, again, just make it part of the series where it is needed.
> 

Greg, Rafael, How do you wish to route this patch in?

This patch is a dependency of [1] which goes through my tree.
If  you can provide an ack, I can pick up the patch through my tree,
else we will end up with dependency issue here.

[1] https://lore.kernel.org/all/20241007-tisci-syssuspendresume-v13-0-ed54cd659a49@baylibre.com/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D