linux-kernel - [PATCH v2] kdb: Fix missing argument in dmesg command usage help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241026061555.GA887785@lichtman.org>
Date: Sat, 26 Oct 2024 06:15:55 +0000
From: Nir Lichtman <nir@...htman.org>
To: jason.wessel@...driver.com, daniel.thompson@...aro.org,
	dianders@...omium.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] kdb: Fix missing argument in dmesg command usage help

Problem: Currently when running "help" in KDB, it shows the "dmesg" command
as having only a single argument, when in fact as can be seen in the
implementation of the command (kdb_dmesg) it accepts two arguments

Solution: Add the missing argument to the usage string of the "dmesg" command

Reviewed-by: Douglas Anderson <dianders@...omium.org>
Suggested-by: Douglas Anderson <dianders@...omium.org>
Signed-off-by: Nir Lichtman <nir@...htman.org>
---
 kernel/debug/kdb/kdb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index f5f7d7fb5936..5f56ade565a6 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -2827,7 +2827,7 @@ static kdbtab_t maintab[] = {
 #if defined(CONFIG_PRINTK)
 	{	.name = "dmesg",
 		.func = kdb_dmesg,
-		.usage = "[lines]",
+		.usage = "[lines] [adjust]",
 		.help = "Display syslog buffer",
 		.flags = KDB_ENABLE_ALWAYS_SAFE,
 	},
-- 
2.39.2