[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241025171131.9ceabcec32ff4c569d87875f@linux-foundation.org>
Date: Fri, 25 Oct 2024 17:11:31 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Suren Baghdasaryan <surenb@...gle.com>, "Liam R . Howlett"
<Liam.Howlett@...cle.com>, Matthew Wilcox <willy@...radead.org>, Vlastimil
Babka <vbabka@...e.cz>, "Paul E . McKenney" <paulmck@...nel.org>, Jann Horn
<jannh@...gle.com>, David Hildenbrand <david@...hat.com>,
linux-mm@...ck.org, linux-kernel@...r.kernel.org, Muchun Song
<muchun.song@...ux.dev>, Richard Henderson <richard.henderson@...aro.org>,
Matt Turner <mattst88@...il.com>, Thomas Bogendoerfer
<tsbogend@...ha.franken.de>, "James E . J . Bottomley"
<James.Bottomley@...senpartnership.com>, Helge Deller <deller@....de>,
Chris Zankel <chris@...kel.net>, Max Filippov <jcmvbkbc@...il.com>, Arnd
Bergmann <arnd@...nel.org>, linux-alpha@...r.kernel.org,
linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
linux-arch@...r.kernel.org, Shuah Khan <shuah@...nel.org>, Christian
Brauner <brauner@...nel.org>, linux-kselftest@...r.kernel.org, Sidhartha
Kumar <sidhartha.kumar@...cle.com>, Jeff Xu <jeffxu@...omium.org>,
Christoph Hellwig <hch@...radead.org>, linux-api@...r.kernel.org, John
Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v3 3/5] mm: madvise: implement lightweight guard page
mechanism
On Thu, 24 Oct 2024 08:25:46 +0100 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:
> I actually do plan to extend this work to support shmem and file-backed
> mappings in the future as a revision to this work.
Useful, thanks. I pasted this in.
> >
> > (generally, it would be nice to include the proposed manpage update at
> > this time, so people can review it while the code change is fresh in
> > their minds)
>
> It'd be nice to have the man pages live somewhere within the kernel so we
> can do this as part of the patch change as things evolve during review, but
> obviously moving things about like that is out of scope for this discussion
> :)
Yes, that would be good. At present the linkage is so poor that things
could get lost.
I guess one thing we could do is to include the proposed manpage update
within the changelogs. That way it's stored somewhere and gets reviewed
alongside the patches themselves.
> I do explicitly intend to send a manpage update once this series lands
> however.
That's late, IMO. Sometimes reviewing manpage updates leads people to
ask "hey. what about X" or "hey, that's wrong". Michael Kerrisk was
good at finding such holes, back in the day.
Powered by blists - more mailing lists