linux-kernel - Re: [PATCH] crypto: cavium - Fix the if condition to exit loop after timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZxyUPf9qjZlSA-bK@gondor.apana.org.au>
Date: Sat, 26 Oct 2024 15:03:25 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "Everest K.C." <everestkc@...restkc.com.np>
Cc: gcherian@...vell.com, davem@...emloft.net, skhan@...uxfoundation.org,
	linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: cavium - Fix the if condition to exit loop after
 timeout

On Fri, Oct 18, 2024 at 10:23:10AM -0600, Everest K.C. wrote:
> The while loop breaks in the first run because of incorrect
> if condition. It also causes the statements after the if to
> appear dead.
> Fix this by changing the condition from if(timeout--) to
> if(!timeout--).
> 
> This bug was reported by Coverity Scan.
> Report:
> CID 1600859: (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: udelay(30UL);
> 
> Fixes: 9e2c7d99941d ("crypto: cavium - Add Support for Octeon-tx CPT Engine")
> Signed-off-by: Everest K.C. <everestkc@...restkc.com.np>
> ---
>  drivers/crypto/cavium/cpt/cptpf_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt