lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZxyUZWbn2wnz3ra4@gondor.apana.org.au>
Date: Sat, 26 Oct 2024 15:04:05 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org, guanwentao@...ontech.com,
	wangyuli@...ontech.com
Subject: Re: [PATCH] crypto: mips/crc32 - fix the CRC32C implementation

Eric Biggers <ebiggers@...nel.org> wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Commit ca459e5f826f ("crypto: mips/crc32 - Clean up useless assignment
> operations") changed crc32c_mips_le_hw() to use the instructions that
> use the "regular" CRC32 polynomial instead of the Castagnoli polynomial.
> Therefore it can't be computing CRC32C values correctly anymore.
> 
> I haven't been successful in running a MIPS kernel in QEMU, but based on
> code review this is the fix that is needed.
> 
> Fixes: ca459e5f826f ("crypto: mips/crc32 - Clean up useless assignment operations")
> Cc: Guan Wentao <guanwentao@...ontech.com>
> Cc: WangYuli <wangyuli@...ontech.com>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> 
> This is a regression in 6.12, so it should be fixed in a 6.12-rc.
> 
> arch/mips/crypto/crc32-mips.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ