linux-kernel - Re: [RFC PATCH v1] tracing: Fix syscall tracepoint use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241026031314.0f53e7fa@rorschach.local.home>
Date: Sat, 26 Oct 2024 03:13:14 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Jordan Rife <jrife@...gle.com>, acme@...nel.org,
 alexander.shishkin@...ux.intel.com, andrii.nakryiko@...il.com,
 ast@...nel.org, bpf@...r.kernel.org, joel@...lfernandes.org,
 linux-kernel@...r.kernel.org, mark.rutland@....com, mhiramat@...nel.org,
 mingo@...hat.com, mjeanson@...icios.com, namhyung@...nel.org,
 paulmck@...nel.org, peterz@...radead.org,
 syzbot+b390c8062d8387b6272a@...kaller.appspotmail.com, yhs@...com
Subject: Re: [RFC PATCH v1] tracing: Fix syscall tracepoint use-after-free

On Fri, 25 Oct 2024 15:38:48 -0400
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> > I'm curious if it might be better to add some field to struct
> > tracepoint like "sleepable" rather than adding a special case here
> > based on the name? Of course, if it's only ever going to be these
> > two cases then maybe adding a new field doesn't make sense.  
> 
> I know Steven is reluctant to bloat the tracepoint struct because there
> are lots of tracepoint instances (thousands). So for now I thought that
> just comparing the name would be a good start.

You are correct. I really trying to keep the footprint of
tracepoints/events down.

> 
> We can eventually go a different route as well: introduce a section just
> to put the syscall tracepoints, and compare the struct tracepoint
> pointers to the section begin/end range. But it's rather complex
> for what should remain a simple fix.

A separate section could work.

-- Steve