linux-kernel - Re: [PATCH] i2c: busses: fix uninit-value in pci1xxxx_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <771b8d5a-f0a9-4d82-bb59-5fdd1fe7447a@gmail.com>
Date: Sat, 26 Oct 2024 13:09:41 +0530
From: Suraj Sonawane <surajsonawane0215@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: tharunkumar.pasumarthi@...rochip.com,
 kumaravel.thiagarajan@...rochip.com, UNGLinuxDriver@...rochip.com,
 linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: busses: fix uninit-value in pci1xxxx_i2c_xfer

On 24/10/24 04:32, Andi Shyti wrote:
> Hi Suraj,
> 
> Thanks for your patch, but...
> 
> On Wed, Oct 23, 2024 at 12:38:45AM +0530, Suraj Sonawane wrote:
>> Fix an issue reported by the smatch static analysis tool:
>> drivers/i2c/busses/i2c-mchp-pci1xxxx.c:1030 pci1xxxx_i2c_xfer() error:
>> uninitialized symbol 'retval'.
>>
>> The error occurs because retval may be used without being set if the
>> transfer loop does not execute (e.g., when num is 0). This could cause
>> the function to return an undefined value, leading to unpredictable
>> behavior.
> 
> ... if num is '0', then we would never reach here, check
> __i2c_transfer().
> 
> Thanks,
> Andi
> 
>> Initialize retval to 0 before the transfer loop to ensure that the
>> function returns a valid value even if no transfers are processed. This
>> change also preserves proper error handling within the loop.
>>
>> Signed-off-by: Suraj Sonawane <surajsonawane0215@...il.com>
Thank you for reviewing and clarifying.

Best regards,
Suraj Sonawane