linux-kernel - Re: [PATCH v2 1/2] crypto: hisilicon/sec2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxyvT1PnY83Ilvyb@gondor.apana.org.au>
Date: Sat, 26 Oct 2024 16:58:55 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "linwenkai (C)" <linwenkai6@...ilicon.com>
Cc: Chenghai Huang <huangchenghai2@...wei.com>, davem@...emloft.net,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	liulongfang@...wei.com, shenyang39@...wei.com, qianweili@...wei.com,
	wangzhou1@...ilicon.com
Subject: Re: [PATCH v2 1/2] crypto: hisilicon/sec2 - fix for aead icv error

On Sat, Oct 26, 2024 at 03:50:58PM +0800, linwenkai (C) wrote:
>
> Hi, do you want me to remove this variable and use the old way to get the
> authsize?

The authsize parameter is meant to be constant throughout a single
encryption/decryption operation.  So saving a copy of it for the
duration of that operation makes no sense.

What is the actual problem that you're trying to fix?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt