[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4350a4f0-fa9d-43a6-bec5-68f752d1395c@redhat.com>
Date: Sat, 26 Oct 2024 12:06:55 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Mario Limonciello <mario.limonciello@....com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
Maximilian Luz <luzmaximilian@...il.com>, Lee Chun-Yi <jlee@...e.com>,
Shyam Sundar S K <Shyam-sundar.S-k@....com>,
Corentin Chary <corentin.chary@...il.com>, "Luke D . Jones"
<luke@...nes.dev>, Ike Panhc <ike.pan@...onical.com>,
Henrique de Moraes Holschuh <hmh@....eng.br>,
Alexis Belmonte <alexbelm48@...il.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Ai Chao <aichao@...inos.cn>, Gergo Koteles <soyer@....hu>,
open list <linux-kernel@...r.kernel.org>,
"open list:ACPI" <linux-acpi@...r.kernel.org>,
"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
<platform-driver-x86@...r.kernel.org>,
"open list:THINKPAD ACPI EXTRAS DRIVER"
<ibm-acpi-devel@...ts.sourceforge.net>,
Mark Pearson <mpearson-lenovo@...ebb.ca>,
Matthew Schwartz <matthew.schwartz@...ux.dev>
Subject: Re: [PATCH 2/8] platform/surface: aggregator: Add platform handler
pointer to device
Hi,
On 25-Oct-24 9:30 PM, Mario Limonciello wrote:
> To be able to reference the platform handler in remove, add
> a pointer to `struct ssam_device`.
>
> Tested-by: Matthew Schwartz <matthew.schwartz@...ux.dev>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@...hat.com>
Regards,
Hans
> ---
> drivers/platform/surface/surface_platform_profile.c | 1 +
> include/linux/surface_aggregator/device.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/platform/surface/surface_platform_profile.c b/drivers/platform/surface/surface_platform_profile.c
> index 61aa488a80eb5..958afd7bce223 100644
> --- a/drivers/platform/surface/surface_platform_profile.c
> +++ b/drivers/platform/surface/surface_platform_profile.c
> @@ -210,6 +210,7 @@ static int surface_platform_profile_probe(struct ssam_device *sdev)
> return -ENOMEM;
>
> tpd->sdev = sdev;
> + sdev->tpd = tpd;
>
> tpd->handler.name = "Surface Platform Profile";
> tpd->handler.profile_get = ssam_platform_profile_get;
> diff --git a/include/linux/surface_aggregator/device.h b/include/linux/surface_aggregator/device.h
> index 8cd8c38cf3f30..6a72b5bdc8782 100644
> --- a/include/linux/surface_aggregator/device.h
> +++ b/include/linux/surface_aggregator/device.h
> @@ -164,6 +164,7 @@ enum ssam_device_flags {
> * @dev: Driver model representation of the device.
> * @ctrl: SSAM controller managing this device.
> * @uid: UID identifying the device.
> + * @tpd: Platform profile device data.
> * @flags: Device state flags, see &enum ssam_device_flags.
> */
> struct ssam_device {
> @@ -171,6 +172,7 @@ struct ssam_device {
> struct ssam_controller *ctrl;
>
> struct ssam_device_uid uid;
> + struct ssam_platform_profile_device *tpd;
>
> unsigned long flags;
> };
Powered by blists - more mailing lists