linux-kernel - Re: [PATCH v2] dt-bindings: soc: bcm: Convert raspberrypi,bcm2835-power to Dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d5f9959-17c9-4e61-a6df-ebd187f422e6@kernel.org>
Date: Sat, 26 Oct 2024 13:26:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Karan Sanghavi <karansanghvi98@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>, devicetree@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>,
 Alexander Aring <alex.aring@...il.com>, Eric Anholt <eric@...olt.net>
Subject: Re: [PATCH v2] dt-bindings: soc: bcm: Convert
 raspberrypi,bcm2835-power to Dt schema

On 25/10/2024 20:22, Karan Sanghavi wrote:
>>> +
>>> +examples:
>>> +  - |
>>> +    power: power {
>>
>> Drop label. Node name: power-controller
>>
>> I don't think this passes tests because of this. See power-domain.yaml
>> schema.
>>
> 
> Below code is from bcm2711-rpi-4-b.dts decompiled from the dtb file.

Uh? Why would we ever care about decompiling some DTBs?


> 
> firmware {
>          compatible = "raspberrypi,bcm2835-firmware\0simple-mfd";
>          mboxes = <0x1d>;
>          phandle = <0x1e>;
>         ...
> };
> 
> power {
>          compatible = "raspberrypi,bcm2835-power";
>          firmware = <0x1e>;
>          #power-domain-cells = <0x01>;
>          phandle = <0x0b>;
> };
> 
> I had a doubt that as above the raspberrypi,bcm2835-power compatible node
> is defined with power keyword, so should I still rename the node as
> power-controll or keep it has power?

I don't understand your arguments. Schema expects this to have proper
name (see bindings). DT spec as well.

> 
> Also it does passes the dt_binding_check and CHECK_DTBS=y broadcom/bcm2711-rpi-4-b.dtb
> but does gives the message as
> soc: power: 'ranges' is a required property
> so do I need to add the range property here?

I have no clue what you are testing here. We do not care about some out
of tree DTB. And if you ask about upstream, then take conversions tasks
after reading this:

https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY

BTW, your patch has patch errors which *have to be fixed* as well. Apply
your patch to see them. Run checkpatch.

Best regards,
Krzysztof