linux-kernel - Re: [PATCH] drm/msm/gpu: Fix missing error check for dev_pm_qos_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mq5tggw4x6gsiidxzllay55wlqfvtdvdgwsirty5uqjfuzw3ym@j2vuy22ixffi>
Date: Sat, 26 Oct 2024 18:36:49 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: robdclark@...il.com, sean@...rly.run, konradybcio@...nel.org, 
	quic_abhinavk@...cinc.com, marijn.suijten@...ainline.org, airlied@...il.com, 
	simona@...ll.ch, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm/gpu: Fix missing error check for
 dev_pm_qos_add_request()

On Sat, Oct 26, 2024 at 05:37:38PM +0800, Jinjie Ruan wrote:
> dev_pm_qos_add_request() can fail, and it returns -EINVAL in case of
> wrong parameters, return -ENOMEM if there's not enough memory to allocate
> for data structures, and return -ENODEV if the device has just been
> removed from the system. If it fails in msm_devfreq_init(), there is
> no point in going on, also call dev_pm_qos_remove_request() in the next
> error path is also meaningless
> 
> Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  drivers/gpu/drm/msm/msm_gpu_devfreq.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 

I'm sorry, a similar patch has already been sent:

https://patchwork.freedesktop.org/series/140162/

-- 
With best wishes
Dmitry