| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202410270016.f3oIhZ0P-lkp@intel.com>
Date: Sun, 27 Oct 2024 01:23:47 +0800
From: kernel test robot <lkp@...el.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
Linus Walleij <linus.walleij@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpio: relax the Kconfig dependency on OF_GPIO in drivers
Hi Bartosz,
kernel test robot noticed the following build errors:
[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linus/master v6.12-rc4 next-20241025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/gpio-relax-the-Kconfig-dependency-on-OF_GPIO-in-drivers/20241025-032925
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link: https://lore.kernel.org/r/20241024192758.91748-1-brgl%40bgdev.pl
patch subject: [PATCH] gpio: relax the Kconfig dependency on OF_GPIO in drivers
config: m68k-randconfig-r051-20241026 (https://download.01.org/0day-ci/archive/20241027/202410270016.f3oIhZ0P-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241027/202410270016.f3oIhZ0P-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410270016.f3oIhZ0P-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/gpio/gpio-brcmstb.c: In function 'brcmstb_gpio_of_xlate':
>> drivers/gpio/gpio-brcmstb.c:406:15: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
406 | if (gc->of_gpio_n_cells != 2) {
| ^~
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from include/linux/spinlock.h:56,
from include/linux/irq.h:14,
from include/linux/irqchip/chained_irq.h:10,
from include/linux/gpio/driver.h:8,
from drivers/gpio/gpio-brcmstb.c:5:
drivers/gpio/gpio-brcmstb.c:411:46: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
411 | if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells))
| ^~
include/asm-generic/bug.h:123:32: note: in definition of macro 'WARN_ON'
123 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~
drivers/gpio/gpio-brcmstb.c: In function 'brcmstb_gpio_probe':
drivers/gpio/gpio-brcmstb.c:689:19: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
689 | gc->of_gpio_n_cells = 2;
| ^~
>> drivers/gpio/gpio-brcmstb.c:690:19: error: 'struct gpio_chip' has no member named 'of_xlate'
690 | gc->of_xlate = brcmstb_gpio_of_xlate;
| ^~
--
drivers/gpio/gpio-lpc32xx.c: In function 'lpc32xx_gpio_probe':
>> drivers/gpio/gpio-lpc32xx.c:517:49: error: 'struct gpio_chip' has no member named 'of_xlate'
517 | lpc32xx_gpiochip[i].chip.of_xlate = lpc32xx_of_xlate;
| ^
>> drivers/gpio/gpio-lpc32xx.c:518:49: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
518 | lpc32xx_gpiochip[i].chip.of_gpio_n_cells = 3;
| ^
--
drivers/gpio/gpio-mt7621.c: In function 'mediatek_gpio_bank_probe':
>> drivers/gpio/gpio-mt7621.c:246:17: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
246 | rg->chip.of_gpio_n_cells = 2;
| ^
>> drivers/gpio/gpio-mt7621.c:247:17: error: 'struct gpio_chip' has no member named 'of_xlate'
247 | rg->chip.of_xlate = mediatek_gpio_xlate;
| ^
--
In file included from arch/m68k/include/asm/bug.h:32,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from include/linux/spinlock.h:56,
from include/linux/irq.h:14,
from include/linux/irqchip/chained_irq.h:10,
from include/linux/gpio/driver.h:8,
from drivers/gpio/gpio-tegra186.c:9:
drivers/gpio/gpio-tegra186.c: In function 'tegra186_gpio_of_xlate':
>> drivers/gpio/gpio-tegra186.c:469:25: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
469 | if (WARN_ON(chip->of_gpio_n_cells < 2))
| ^~
include/asm-generic/bug.h:123:32: note: in definition of macro 'WARN_ON'
123 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~
drivers/gpio/gpio-tegra186.c:472:44: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
472 | if (WARN_ON(spec->args_count < chip->of_gpio_n_cells))
| ^~
include/asm-generic/bug.h:123:32: note: in definition of macro 'WARN_ON'
123 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~
drivers/gpio/gpio-tegra186.c: In function 'tegra186_gpio_irq_domain_translate':
drivers/gpio/gpio-tegra186.c:676:31: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
676 | if (WARN_ON(gpio->gpio.of_gpio_n_cells < 2))
| ^
include/asm-generic/bug.h:123:32: note: in definition of macro 'WARN_ON'
123 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~
drivers/gpio/gpio-tegra186.c:679:53: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
679 | if (WARN_ON(fwspec->param_count < gpio->gpio.of_gpio_n_cells))
| ^
include/asm-generic/bug.h:123:32: note: in definition of macro 'WARN_ON'
123 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~
drivers/gpio/gpio-tegra186.c: At top level:
>> drivers/gpio/gpio-tegra186.c:462:12: warning: 'tegra186_gpio_of_xlate' defined but not used [-Wunused-function]
462 | static int tegra186_gpio_of_xlate(struct gpio_chip *chip,
| ^~~~~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
vim +406 drivers/gpio/gpio-brcmstb.c
3b0213d56eb7f7 Gregory Fong 2015-05-28 398
3b0213d56eb7f7 Gregory Fong 2015-05-28 399 static int brcmstb_gpio_of_xlate(struct gpio_chip *gc,
3b0213d56eb7f7 Gregory Fong 2015-05-28 400 const struct of_phandle_args *gpiospec, u32 *flags)
3b0213d56eb7f7 Gregory Fong 2015-05-28 401 {
3b0213d56eb7f7 Gregory Fong 2015-05-28 402 struct brcmstb_gpio_priv *priv = brcmstb_gpio_gc_to_priv(gc);
0f4630f3720e7e Linus Walleij 2015-12-04 403 struct brcmstb_gpio_bank *bank = gpiochip_get_data(gc);
3b0213d56eb7f7 Gregory Fong 2015-05-28 404 int offset;
3b0213d56eb7f7 Gregory Fong 2015-05-28 405
3b0213d56eb7f7 Gregory Fong 2015-05-28 @406 if (gc->of_gpio_n_cells != 2) {
3b0213d56eb7f7 Gregory Fong 2015-05-28 407 WARN_ON(1);
3b0213d56eb7f7 Gregory Fong 2015-05-28 408 return -EINVAL;
3b0213d56eb7f7 Gregory Fong 2015-05-28 409 }
3b0213d56eb7f7 Gregory Fong 2015-05-28 410
3b0213d56eb7f7 Gregory Fong 2015-05-28 411 if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells))
3b0213d56eb7f7 Gregory Fong 2015-05-28 412 return -EINVAL;
3b0213d56eb7f7 Gregory Fong 2015-05-28 413
ec37529e544c59 Doug Berger 2024-04-23 414 offset = gpiospec->args[0] - bank->gc.offset;
19a7b6940b7812 Gregory Fong 2015-07-31 415 if (offset >= gc->ngpio || offset < 0)
3b0213d56eb7f7 Gregory Fong 2015-05-28 416 return -EINVAL;
3b0213d56eb7f7 Gregory Fong 2015-05-28 417
3b0213d56eb7f7 Gregory Fong 2015-05-28 418 if (unlikely(offset >= bank->width)) {
3b0213d56eb7f7 Gregory Fong 2015-05-28 419 dev_warn_ratelimited(&priv->pdev->dev,
3b0213d56eb7f7 Gregory Fong 2015-05-28 420 "Received request for invalid GPIO offset %d\n",
3b0213d56eb7f7 Gregory Fong 2015-05-28 421 gpiospec->args[0]);
3b0213d56eb7f7 Gregory Fong 2015-05-28 422 }
3b0213d56eb7f7 Gregory Fong 2015-05-28 423
3b0213d56eb7f7 Gregory Fong 2015-05-28 424 if (flags)
3b0213d56eb7f7 Gregory Fong 2015-05-28 425 *flags = gpiospec->args[1];
3b0213d56eb7f7 Gregory Fong 2015-05-28 426
3b0213d56eb7f7 Gregory Fong 2015-05-28 427 return offset;
3b0213d56eb7f7 Gregory Fong 2015-05-28 428 }
3b0213d56eb7f7 Gregory Fong 2015-05-28 429
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists