linux-kernel - Re: [PATCH 1/2] time: revert cleanup on msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7787a08-3b06-4d52-8e4b-8a82bfdbe21b@infradead.org>
Date: Sat, 26 Oct 2024 12:32:44 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Miguel Ojeda <ojeda@...nel.org>, John Stultz <jstultz@...gle.com>,
 Thomas Gleixner <tglx@...utronix.de>
Cc: Stephen Boyd <sboyd@...nel.org>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Ingo Molnar <mingo@...nel.org>,
 Nicholas Mc Guire <hofrat@...dl.org>, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH 1/2] time: revert cleanup on msecs_to_jiffies()
 documentation



On 10/25/24 4:01 AM, Miguel Ojeda wrote:
> The documentation's intention is to compare `msecs_to_jiffies` (first
> sentence) with `__msecs_to_jiffies` (second sentence), which is what the
> original documentation did. One of the cleanups in commit f3cb80804b82
> ("time: Fix various kernel-doc problems") may have thought the paragraph
> was talking about the latter since that is what it is being documented.
> 
> Thus revert that part of the change.
> 
> Fixes: f3cb80804b82 ("time: Fix various kernel-doc problems")
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  kernel/time/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/time.c b/kernel/time/time.c
> index 642647f5046b..e1879ca32103 100644
> --- a/kernel/time/time.c
> +++ b/kernel/time/time.c
> @@ -558,7 +558,7 @@ EXPORT_SYMBOL(ns_to_timespec64);
>   *   handling any 32-bit overflows.
>   *   for the details see __msecs_to_jiffies()
>   *
> - * __msecs_to_jiffies() checks for the passed in value being a constant
> + * msecs_to_jiffies() checks for the passed in value being a constant
>   * via __builtin_constant_p() allowing gcc to eliminate most of the
>   * code, __msecs_to_jiffies() is called if the value passed does not
>   * allow constant folding and the actual conversion must be done at
> 
> base-commit: 42f7652d3eb527d03665b09edac47f85fb600924

-- 
~Randy