linux-kernel - Re: [PATCH v4 11/11] clk: qcom: add SAR2130P GPU Clock Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bwmoa5jyyxqyrspq4hjcr6cn475bmo5jhb5fenpmohoucuvop7@mrm7faeivymw>
Date: Sun, 27 Oct 2024 01:19:12 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bjorn Andersson <andersson@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Taniya Das <quic_tdas@...cinc.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH v4 11/11] clk: qcom: add SAR2130P GPU Clock Controller
 support

On Sat, Oct 26, 2024 at 06:47:09PM +0300, Dmitry Baryshkov wrote:
> From: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> Add support for the GPU Clock Controller as used on the SAR2130P and
> SAR1130P platforms.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>  drivers/clk/qcom/Kconfig          |   9 +
>  drivers/clk/qcom/Makefile         |   1 +
>  drivers/clk/qcom/gpucc-sar2130p.c | 503 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 513 insertions(+)
> 
> +
> +static int gpu_cc_sar2130p_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct regmap *regmap;
> +	int ret;

This generates unused variabel warning. I'll send next iteration after
some time.

> +
> +	regmap = qcom_cc_map(pdev, &gpu_cc_sar2130p_desc);
> +	if (IS_ERR(regmap))
> +		return dev_err_probe(dev, PTR_ERR(regmap), "Couldn't map GPU_CC\n");
> +
> +	clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config);
> +	clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config);
> +
> +	/* Keep some clocks always-on */
> +	qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
> +
> +	return qcom_cc_really_probe(dev, &gpu_cc_sar2130p_desc, regmap);
> +}
> +
> +static struct platform_driver gpu_cc_sar2130p_driver = {
> +	.probe = gpu_cc_sar2130p_probe,
> +	.driver = {
> +		.name = "gpu_cc-sar2130p",
> +		.of_match_table = gpu_cc_sar2130p_match_table,
> +	},
> +};
> +module_platform_driver(gpu_cc_sar2130p_driver);
> +
> +MODULE_DESCRIPTION("QTI GPU_CC SAR2130P Driver");
> +MODULE_LICENSE("GPL");
> 
> -- 
> 2.39.5
> 

-- 
With best wishes
Dmitry