linux-kernel - Re: [PATCH] fgraph: Change the name of cpuhp state to "fgraph:online"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241027205952.e9c65a883362d8fdbdd2fe15@kernel.org>
Date: Sun, 27 Oct 2024 20:59:52 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux trace kernel
 <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Thomas Gleixner
 <tglx@...utronix.de>
Subject: Re: [PATCH] fgraph: Change the name of cpuhp state to
 "fgraph:online"

On Thu, 24 Oct 2024 22:29:44 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The cpuhp state name given to cpuhp_setup_state() is "fgraph_idle_init"
> which doesn't really conform to the names that are used for cpu hotplug
> setups. Instead rename it to "fgraph:online" to be in line with other
> states.
> 
> Suggested-by: Masami Hiramatsu <mhiramat@...nel.org>
> Fixes: 2c02f7375e658 ("fgraph: Use CPU hotplug mechanism to initialize idle shadow stacks")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thank you!

> ---
>  kernel/trace/fgraph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
> index cd1c2946018c..69e226a48daa 100644
> --- a/kernel/trace/fgraph.c
> +++ b/kernel/trace/fgraph.c
> @@ -1255,7 +1255,7 @@ int register_ftrace_graph(struct fgraph_ops *gops)
>  	guard(mutex)(&ftrace_lock);
>  
>  	if (!fgraph_initialized) {
> -		ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "fgraph_idle_init",
> +		ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "fgraph:online",
>  					fgraph_cpu_init, NULL);
>  		if (ret < 0) {
>  			pr_warn("fgraph: Error to init cpu hotplug support\n");
> -- 
> 2.45.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>