linux-kernel - Re: [PATCH] mmc: dw_mmc: take SWIOTLB memory size limitation into account

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJM55Z_CU5rwMBm7n10jhGk57_T_HWLKYrYaGoc7qvK9irT5yQ@mail.gmail.com>
Date: Sun, 27 Oct 2024 08:16:20 -0400
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Ulf Hansson <ulf.hansson@...aro.org>, Aurelien Jarno <aurelien@...el32.net>
Cc: William Qiu <william.qiu@...rfivetech.com>, 
	"open list:RISC-V MISC SOC SUPPORT" <linux-riscv@...ts.infradead.org>, Jaehoon Chung <jh80.chung@...sung.com>, 
	Sam Protsenko <semen.protsenko@...aro.org>, 
	"open list:SYNOPSYS DESIGNWARE MMC/SD/SDIO DRIVER" <linux-mmc@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	Ron Economos <re@...z.net>, Jing Luo <jing@...g.rocks>, stable@...r.kernel.org, 
	Adam Green <greena88@...il.com>, Shawn Lin <shawn.lin@...k-chips.com>, sydarn@...ton.me, 
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] mmc: dw_mmc: take SWIOTLB memory size limitation into account

Ulf Hansson wrote:
> + Adam, Arnd, Shawn-Lin, sydarn
>
>
> On Sun, 20 Oct 2024 at 16:30, Aurelien Jarno <aurelien@...el32.net> wrote:
> >
> > The Synopsys DesignWare mmc controller on the JH7110 SoC
> > (dw_mmc-starfive.c driver) is using a 32-bit IDMAC address bus width,
> > and thus requires the use of SWIOTLB.
> >
> > The commit 8396c793ffdf ("mmc: dw_mmc: Fix IDMAC operation with pages
> > bigger than 4K") increased the max_seq_size, even for 4K pages, causing
> > "swiotlb buffer is full" to happen because swiotlb can only handle a
> > memory size up to 256kB only.
> >
> > Fix the issue, by making sure the dw_mmc driver doesn't use segments
> > bigger than what SWIOTLB can handle.
> >
> > Reported-by: Ron Economos <re@...z.net>
> > Reported-by: Jing Luo <jing@...g.rocks>
> > Fixes: 8396c793ffdf ("mmc: dw_mmc: Fix IDMAC operation with pages bigger than 4K")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Aurelien Jarno <aurelien@...el32.net>
>
> Thanks for working on this!

+1

> Looks like we have managed to mess things
> up. Besides the issue that you have been working on to fix, apparently
> there seems to be another one too [1].
>
> Unfortunately, $subject patch doesn't seem to fix the problem in [1],
> as has been reported by Adam.
>
> I have looped in some more people to this thread, hopefully we agree
> on how this should be fixed properly. Otherwise, I tend to say that we
> should simply revert the offending commit and start over.

Yes, unfortunately this patch also doesn't fix MMC when running 6.12-rc4 on the
StarFive VisionFive V1 (JH7100 SoC).

/Emil