linux-kernel - Re: [PATCH v3 1/3] dt-bindings: leds: Add LED1202 LED Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84dcf231-df5d-7503-f61c-10a30d092287@gmail.com>
Date: Sun, 27 Oct 2024 15:31:38 +0100
From: Jacek Anaszewski <jacek.anaszewski@...il.com>
To: Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>,
 pavel@....cz, lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: leds: Add LED1202 LED Controller

Hi Vicentiu,

On 10/26/24 16:46, Vicentiu Galanopulo wrote:
> The LED1202 is a 12-channel low quiescent current LED driver with:
>    * Supply range from 2.6 V to 5 V
>    * 20 mA current capability per channel
>    * 1.8 V compatible I2C control interface
>    * 8-bit analog dimming individual control
>    * 12-bit local PWM resolution
>    * 8 programmable patterns
> 
> If the led node is present in the controller then the channel is
> set to active.
> 
> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>
> ---
> 
> Changes in v3:
>    - remove active property
> Changes in v2:
>    - renamed label to remove color from it
>    - add color property for each node
>    - add function and function-enumerator property for each node
> 
>   .../devicetree/bindings/leds/st,led1202.yml   | 103 ++++++++++++++++++
>   1 file changed, 103 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/st,led1202.yml
> 
> diff --git a/Documentation/devicetree/bindings/leds/st,led1202.yml b/Documentation/devicetree/bindings/leds/st,led1202.yml
> new file mode 100644
> index 000000000000..f64273599181
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/st,led1202.yml
> @@ -0,0 +1,103 @@
> +patternProperties:
> +    "^led@[0-9a-f]+$":
> +    type: object
> +    $ref: common.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +        reg:
> +        minimum: 0
> +        maximum: 11
> +
> +    required:
> +        - reg
> +
> +additionalProperties: false
> +
> +examples:
> +    - |
> +        #include <dt-bindings/leds/common.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        led-controller@58 {
> +            compatible = "st,led1202";
> +            reg = <0x58>;
> +            address-cells = <1>;
> +            size-cells = <0>;
> +
> +            led@0 {
> +                reg = <0>;
> +                label = "led1";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_RED>;
> +                function-enumerator = <1>;

You should use devm_led_classdev_register_ext() to let LED core create
LED class device name basing on the above three properties.
'label' property will be useless in that case, so please drop it and
avoid constructing LED name in the driver.

> +            };
> +
> +            led@1 {
> +                reg = <1>;
> +                label = "led2";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_GREEN>;
> +                function-enumerator = <2>;
> +            };
> +
> +            led@2 {
> +                reg = <2>;
> +                label = "led3";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_BLUE>;
> +                function-enumerator = <3>;
> +            };
> +
> +            led@3 {
> +                reg = <3>;
> +                label = "led4";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_RED>;
> +                function-enumerator = <4>;
> +            };
> +
> +            led@4 {
> +                reg = <4>;
> +                label = "led5";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_GREEN>;
> +                function-enumerator = <5>;
> +            };
> +
> +            led@5 {
> +                reg = <5>;
> +                label = "led6";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_BLUE>;
> +                function-enumerator = <6>;
> +            };
> +
> +            led@6 {
> +                reg = <6>;
> +                label = "led7";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_RED>;
> +                function-enumerator = <7>;
> +            };
> +
> +            led@7 {
> +                reg = <7>;
> +                label = "led8";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_GREEN>;
> +                function-enumerator = <8>;
> +            };
> +
> +            led@8 {
> +                reg = <8>;
> +                label = "led9";
> +                function = LED_FUNCTION_STATUS;
> +                color = <LED_COLOR_ID_BLUE>;
> +                function-enumerator = <9>;
> +            };
> +        };
> +    };

-- 
Best regards,
Jacek Anaszewski