linux-kernel - Re: [PATCH] coccinelle: Add str_off_on() and str_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ve49oDYm56R+__5w3Rz8zG9L-0L1zaRrEctg3zTNXdgoQ@mail.gmail.com>
Date: Sun, 27 Oct 2024 20:56:44 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>, Kees Cook <kees@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, Nicolas Palix <nicolas.palix@...g.fr>, linux-hardening@...r.kernel.org, 
	cocci@...ia.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccinelle: Add str_off_on() and str_no_yes() rules

On Sun, Oct 27, 2024 at 5:25 PM Julia Lawall <julia.lawall@...ia.fr> wrote:
> On Sun, 27 Oct 2024, Andy Shevchenko wrote:
> > On Sun, Oct 27, 2024 at 2:59 PM Thorsten Blum <thorsten.blum@...ux.dev> wrote:
> > >
> > > In addition to str_on_off() and str_yes_no(), add rules to search for
> > > str_off_on() and str_no_yes() replacements.
> >
> > I don't know cocci well enough, but this does simply not scale. We
> > also have cases where "Yes"/"No", "YES"/"NO" and all possible
> > variations of that.
>
> Andy, are you concerned about the number of such functions in the kernel
> or the number of rules in the semantic patch.

Rules for the semantic patches I am worried about.

>  There are indeed more
> concise ways to write the semantic patch.

Would be nice to see ways to cover more cases in less lines in the spatch.


-- 
With Best Regards,
Andy Shevchenko