linux-kernel - Re: [PATCH] ceph: return result directly from wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP9hTZTEu7YsV=+J-_TncwKU2paBmFfCjUyB2G52o4qYyg@mail.gmail.com>
Date: Sun, 27 Oct 2024 20:47:35 +0100
From: Ilya Dryomov <idryomov@...il.com>
To: Qianqiang Liu <qianqiang.liu@....com>
Cc: brauner@...nel.org, ceph-devel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: return result directly from wait_for_completion_killable()

On Mon, Oct 14, 2024 at 1:40 PM Qianqiang Liu <qianqiang.liu@....com> wrote:
>
> Simplify the code by returning the result of
> wait_for_completion_killable() directly, instead of calling it
> separately and then returning 0.
>
> No functional changes are introduced, this is a simple refactor

Hi Qianqiang,

I don't think this statement is true.  If the wait is interrupted,
wait_for_completion_killable() returns -ERESTARTSYS and currently
ceph_lock_wait_for_completion() swallows it, similar to how -ERESTARTSYS
coming from ceph_mdsc_do_request() is ignored a few lines above.

Thanks,

                Ilya