linux-kernel - Re: [PATCH v3] bcachefs: Fix NULL ptr dereference in btree_node_iter_and_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ywtf6whalqr56v45crr7afpfni4vhxm3ycly5tpvh2x72uasa@gx6nmtx7uz55>
Date: Sun, 27 Oct 2024 16:19:17 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Piotr Zalewski <pZ010001011111@...ton.me>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org, syzbot+005ef9aa519f30d97657@...kaller.appspotmail.com, 
	Alan Huang <mmpgouride@...il.com>
Subject: Re: [PATCH v3] bcachefs: Fix NULL ptr dereference in
 btree_node_iter_and_journal_peek

On Sun, Oct 27, 2024 at 07:46:52PM +0000, Piotr Zalewski wrote:
> Add NULL check for key returned from bch2_btree_and_journal_iter_peek in
> btree_node_iter_and_journal_peek to avoid NULL ptr dereference in
> bch2_bkey_buf_reassemble.
> 
> When key returned from bch2_btree_and_journal_iter_peek is NULL it means
> that btree topology needs repair. Print topology error message with
> position at which node wasn't found, its parent node information and
> btree_id with level.
> 
> Return error code returned by bch2_topology_error to ensure that topology
> error is handled properly by recovery.
> 
> Reported-by: syzbot+005ef9aa519f30d97657@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=005ef9aa519f30d97657
> Fixes: 5222a4607cd8 ("bcachefs: BTREE_ITER_WITH_JOURNAL")
> Suggested-by: Alan Huang <mmpgouride@...il.com>
> Suggested-by: Kent Overstreet <kent.overstreet@...ux.dev>
> Signed-off-by: Piotr Zalewski <pZ010001011111@...ton.me>

Thanks - applied.