linux-kernel - Re: [PATCH] libceph: Remove crush deadcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOi1vP9au=SqKfmyD79YA3gCGOCj1FjLNJxtF9N_k0cafCJ3uw@mail.gmail.com>
Date: Sun, 27 Oct 2024 21:40:53 +0100
From: Ilya Dryomov <idryomov@...il.com>
To: linux@...blig.org
Cc: xiubli@...hat.com, ceph-devel@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libceph: Remove crush deadcode

On Sat, Oct 12, 2024 at 12:47 AM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> crush_bucket_alg_name(), crush_get_bucket_item_weight(), crush_hash32(),
> and crush_hash32_5() were added by commit
> 5ecc0a0f8128 ("ceph: CRUSH mapping algorithm")
> in 2009 but never used.
>
> crush_hash_name() was added a little later by commit
> fb690390e305 ("ceph: make CRUSH hash function a bucket property")
> and also not used.
>
> Remove them.

Hi David,

The implementation of the CRUSH algorithm is shared with userspace and
these functions are used there (except for crush_hash32_5() perhaps).
They are all trivial code, so I'd prefer to keep them for convenience.

Thanks,

                Ilya