linux-kernel - Re: [PATCH 4/4] ASoC: dt-bindings: maxim,max98390: Document maxim,dsm_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r2qtuopc6d2vygxghgydole5ixxr4z5weougk7ldadyma4zi56@sp34zufvzdaq>
Date: Sun, 27 Oct 2024 21:59:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Fei Shao <fshao@...omium.org>
Cc: Mark Brown <broonie@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Rob Herring <robh@...nel.org>, Steve Lee <steves.lee@...imintegrated.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 4/4] ASoC: dt-bindings: maxim,max98390: Document
 maxim,dsm_param_name property

On Fri, Oct 25, 2024 at 06:44:44PM +0800, Fei Shao wrote:
> Add the missing "maxim,dsm_param_name" property in the binding.
> This property specifies the customized DSM parameter binary name.
> 
> Signed-off-by: Fei Shao <fshao@...omium.org>
> ---
> 
>  Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> index 5bd235cf15e6..fa4749735070 100644
> --- a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> @@ -32,6 +32,10 @@ properties:
>      minimum: 1
>      maximum: 8388607
>  
> +  maxim,dsm_param_name:
> +    description: The DSM parameter binary name (e.g. dsm_param.bin).
> +    $ref: /schemas/types.yaml#/definitions/string

NAK, you cannot document properties post-factum. It's not a property
coming from 2014.

For me, this is obvious that this is for ACPI and if you want to use it
for DT platforms, go through proper review.

In any case: NAK for this and other ACPI properties.

Best regards,
Krzysztof