linux-kernel - Re: [PATCH v5 07/13] iommufd/viommu: Add iommufd_viommu_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zx7DdPmEF/9aU70W@Asurada-Nvidia>
Date: Sun, 27 Oct 2024 15:49:24 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Zhangfei Gao <zhangfei.gao@...aro.org>
CC: <jgg@...dia.com>, <kevin.tian@...el.com>, <will@...nel.org>,
	<joro@...tes.org>, <suravee.suthikulpanit@....com>, <robin.murphy@....com>,
	<dwmw2@...radead.org>, <baolu.lu@...ux.intel.com>, <shuah@...nel.org>,
	<linux-kernel@...r.kernel.org>, <iommu@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kselftest@...r.kernel.org>,
	<eric.auger@...hat.com>, <jean-philippe@...aro.org>, <mdf@...nel.org>,
	<mshavit@...gle.com>, <shameerali.kolothum.thodi@...wei.com>,
	<smostafa@...gle.com>, <yi.l.liu@...el.com>, <aik@....com>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v5 07/13] iommufd/viommu: Add iommufd_viommu_find_dev
 helper

On Sun, Oct 27, 2024 at 11:02:31PM +0800, Zhangfei Gao wrote:
> On Sat, 26 Oct 2024 at 07:51, Nicolin Chen <nicolinc@...dia.com> wrote:
> > +/* Caller should xa_lock(&viommu->vdevs) to protect the return value */
> > +struct device *iommufd_viommu_find_dev(struct iommufd_viommu *viommu,
> > +                                      unsigned long vdev_id)
> > +{
> > +       struct iommufd_vdevice *vdev;
> > +
> > +       lockdep_is_held(&viommu->vdevs.xa_lock);
> > +
> > +       vdev = xa_load(&viommu->vdevs, vdev_id);
> > +       return vdev ? vdev->idev->dev : NULL;
> > +}
> 
> Got this error?
> 
> ld: Unexpected GOT/PLT entries detected!
> ld: Unexpected run-time procedure linkages detected!
> ld: drivers/iommu/iommufd/driver.o: in function `iommufd_viommu_find_dev':
> linux/drivers/iommu/iommufd/driver.c:47: undefined reference to
> `lockdep_is_held'
> make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
> make[1]: *** [/home/linaro/iommufd/linux/Makefile:1166: vmlinux] Error 2
> make: *** [Makefile:224: __sub-make] Error 2

Should fix it with:
-	lockdep_is_held(&viommu->vdevs.xa_lock);
+	lockdep_assert_held(&viommu->vdevs.xa_lock);

Thanks
Nicolin