linux-kernel - Re: [PATCH v2 0/2] hwmon: (pwm-fan) add option to leave fan on shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyjs7ZB7VBUgTN2N_uOukEunko_ZqboAaoqsgcRr8O+txQ@mail.gmail.com>
Date: Sun, 27 Oct 2024 14:31:41 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	devicetree@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Billy Tsai <billy_tsai@...eedtech.com>
Subject: Re: [PATCH v2 0/2] hwmon: (pwm-fan) add option to leave fan on shutdown

2024年10月27日(日) 1:19 Guenter Roeck <linux@...ck-us.net>:
>
> On 10/26/24 01:05, Akinobu Mita wrote:
> > I sent these patches a long time ago, but I didn't cc them to the DT list,
> > so the DT bindings changes weren't reviewed.
> >
> > There have been a lot of changes to pwm-fan since then, and I've updated
> > the patch, so please review again.
> >
>
> What changed ? Where is the change log ?

Sorry, I forgot to write the changelog.

Changes in v2
Patch 1:
- use device_property_read_bool() instead of of_property_read_bool()
- skip calling pwn_fan_cleanup() when newly introduced property is set
  (Since pwm_fan_disable() call in the shutdown() method has been changed to
  pwm_fan_cleanup() call since commit b99152d4f04b ("hwmon: (pwm-fan) Switch
  regulator dynamically"), pwm_fan_disable() no longer exists.)

Patch 2:
- document the new property according to yaml format conversion