linux-kernel - Re: [PATCH v2] arm64: dts: qcom: qcs615: Add QUPv3 configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <hwan6cblfhvwmeos4izmhlzfaydxvs4s66wtjulk22aj3zhy6d@xkaqfgxe2sx2>
Date: Mon, 28 Oct 2024 14:21:32 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Viken Dadhaniya <quic_vdadhani@...cinc.com>, andersson@...nel.org, 
	konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	konrad.dybcio@....qualcomm.com, quic_msavaliy@...cinc.com, quic_anupkulk@...cinc.com
Subject: Re: [PATCH v2] arm64: dts: qcom: qcs615: Add QUPv3 configuration

On Mon, Oct 28, 2024 at 12:33:48PM +0100, Krzysztof Kozlowski wrote:
> On 28/10/2024 12:20, Viken Dadhaniya wrote:
> > Add DT support for QUPv3 Serial Engines.
> > 
> > Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
> > Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
> > Signed-off-by: Viken Dadhaniya <quic_vdadhani@...cinc.com>
> > ---
> > 
> > Build Dependencies:
> > 
> > Base:
> > https://lore.kernel.org/linux-devicetree/20240926-add_initial_support_for_qcs615-v3-5-e37617e91c62@quicinc.com/
> > https://lore.kernel.org/linux-devicetree/20240926-add_initial_support_for_qcs615-v3-6-e37617e91c62@quicinc.com/
> > 
> > Clock: https://lore.kernel.org/linux-devicetree/20240920-qcs615-clock-driver-v2-3-2f6de44eb2aa@quicinc.com/
> > ICC: https://lore.kernel.org/linux-devicetree/20240924143958.25-2-quic_rlaggysh@quicinc.com/
> > Apps SMMU: https://lore.kernel.org/all/20241011063112.19087-1-quic_qqzhou@quicinc.com/
> > 
> > v1 -> v2:
> > 
> > - Add opp-shared property.
> > - Use QCOM_ICC_TAG_ALWAYS flag in interconnect property.
> > 
> > v1 Link: https://lore.kernel.org/all/20241011103346.22925-1-quic_vdadhani@quicinc.com/
> > ---
> >  arch/arm64/boot/dts/qcom/qcs615.dtsi | 642 ++++++++++++++++++++++++++-
> >  1 file changed, 638 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > index 865ead601f85..1d1cdf6f9a74 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> > @@ -5,6 +5,7 @@
> >  
> >  #include <dt-bindings/clock/qcom,qcs615-gcc.h>
> >  #include <dt-bindings/clock/qcom,rpmh.h>
> > +#include <dt-bindings/dma/qcom-gpi.h>
> >  #include <dt-bindings/interconnect/qcom,icc.h>
> >  #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> > @@ -17,6 +18,21 @@
> >  	#address-cells = <2>;
> >  	#size-cells = <2>;
> >  
> > +	aliases {
> > +		i2c1 = &i2c1;
> > +		i2c2 = &i2c2;
> > +		i2c3 = &i2c3;
> > +		i2c4 = &i2c4;
> > +		i2c5 = &i2c5;
> > +		i2c6 = &i2c6;
> > +		i2c7 = &i2c7;
> > +		spi2 = &spi2;
> > +		spi4 = &spi4;
> > +		spi6 = &spi6;
> > +		spi7 = &spi7;
> > +		serial0 = &uart0;
> 
> Comments from v1 apply.
> 

[...]

> > @@ -392,6 +428,24 @@
> >  			#size-cells = <1>;
> >  		};
> >  
> > +		gpi_dma0: qcom,gpi-dma@...000  {
> 
> Nope. Don't post downstream code.

I'd say, as this has repeated the second time, please get the patches
reviewed internally, before sending them for the third time.

-- 
With best wishes
Dmitry