linux-kernel - Re: [PATCH 2/2] misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+doHunzxKroG7m+Ex4Cz-YSwQ7zW2B3tAPi_LFSBfJ_A@mail.gmail.com>
Date: Mon, 28 Oct 2024 08:56:42 -0500
From: Rob Herring <robh@...nel.org>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Stephen Rothwell <sfr@...b.auug.org.au>, 
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org, 
	Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Allan Nielsen <allan.nielsen@...rochip.com>, Horatiu Vultur <horatiu.vultur@...rochip.com>, 
	Steen Hegelund <steen.hegelund@...rochip.com>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 2/2] misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'

On Mon, Oct 28, 2024 at 7:24 AM Herve Codina <herve.codina@...tlin.com> wrote:
>
> dtc generates the following warning when building the LAN966x devicetree
> overlay (lan966x_pci.dtso):
>   Warning (interrupts_property): /fragment@..._overlay__/pci-ep-bus@...ic@...c0120: Missing interrupt-parent
>
> The oic interrupt parent is the PCI device itself. The PCI device node
> is the node on which the dtbo will be applied and this node already has
> properties needed.
>
> In order to remove the warning, add the missing properties in the
> overlay fragment node. Properties in this node will not be added when
> the overlay is applied (which is what we expect) but makes dtc happy.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
> Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> ---
> The referenced commit is in the reset tree
> ---
>  drivers/misc/lan966x_pci.dtso | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>