linux-kernel - Re: linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241027180015.0a995500a00719a9ec7b228b@linux-foundation.org>
Date: Sun, 27 Oct 2024 18:00:15 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Shakeel Butt <shakeel.butt@...ux.dev>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the mm tree

On Mon, 28 Oct 2024 10:36:38 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> After merging the mm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> mm/workingset.c: In function 'workingset_activation':
> mm/workingset.c:598:38: error: implicit declaration of function 'folio_memcg_charged'; did you mean 'folio_memcg_check'? [-Wimplicit-function-declaration]
>   598 |         if (mem_cgroup_disabled() || folio_memcg_charged(folio))
>       |                                      ^~~~~~~~~~~~~~~~~~~
>       |                                      folio_memcg_check
> 
> Caused by commit
> 
>   b4fa93fbd1dc ("memcg: workingset: remove folio_memcg_rcu usage")
> 
> from the mm-unstable branch of the mm tree.
> 
> this build has
> 
> # CONFIG_MEMCG is not set
> 

Thanks.  This?

--- a/include/linux/memcontrol.h~memcg-workingset-remove-folio_memcg_rcu-usage-fix
+++ a/include/linux/memcontrol.h
@@ -1055,6 +1055,11 @@ static inline struct mem_cgroup *folio_m
 	return NULL;
 }
 
+static inline bool folio_memcg_charged(struct folio *folio)
+{
+	return false;
+}
+
 static inline struct mem_cgroup *folio_memcg_check(struct folio *folio)
 {
 	return NULL;
_