linux-kernel - Re: [PATCH 1/2] x86/bugs: Use cpu_smt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241028140634.yjr7i4hwxj7keokm@desk>
Date: Mon, 28 Oct 2024 07:06:34 -0700
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: Breno Leitao <leitao@...ian.org>
Cc: bp@...en8.de, x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>, kernel-team@...a.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86/bugs: Use cpu_smt_possible helper

On Tue, Oct 15, 2024 at 03:51:05AM -0700, Breno Leitao wrote:
> There is a helper function to check if SMT is available. Use this helper
> instead of performing the check manually.
> 
> The helper function cpu_smt_possible() does exactly the same thing as
> was being done manually inside spectre_v2_user_select_mitigation().
> Specifically, it returns false if CONFIG_SMP is disabled, otherwise
> it checks the cpu_smt_control global variable.
> 
> This change improves code consistency and reduces duplication.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>