linux-kernel - Re: [PATCH v2 2/2] dt-bindings: hwmon: pwm-fan: add retain-state-shutdown property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyhCw+62Y+h3Jvh3=0Ocs8XJsSu_vaiPpO_g=65Jo4vUFg@mail.gmail.com>
Date: Mon, 28 Oct 2024 23:57:37 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	devicetree@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, 
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Billy Tsai <billy_tsai@...eedtech.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: hwmon: pwm-fan: add
 retain-state-shutdown property

2024年10月28日(月) 23:22 Krzysztof Kozlowski <krzk@...nel.org>:
>
> On 28/10/2024 13:42, Akinobu Mita wrote:
> > 2024年10月28日(月) 5:38 Krzysztof Kozlowski <krzk@...nel.org>:
> >>
> >> On Sat, Oct 26, 2024 at 05:05:35PM +0900, Akinobu Mita wrote:
> >>> Document new retain-state-shutdown property.
> >>>
> >>> Cc: Jean Delvare <jdelvare@...e.com>
> >>> Cc: Guenter Roeck <linux@...ck-us.net>
> >>> Cc: Rob Herring <robh@...nel.org>
> >>> Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
> >>> Cc: Conor Dooley <conor+dt@...nel.org>
> >>> Cc: Billy Tsai <billy_tsai@...eedtech.com>
> >>> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 4 ++++
> >>>  1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> >>> index 4e5abf7580cc..86a069969e29 100644
> >>> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> >>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> >>> @@ -40,6 +40,10 @@ properties:
> >>>      maximum: 4
> >>>      default: 2
> >>>
> >>> +  retain-state-shutdown:
> >>> +    description: Retain the state of the PWM on shutdown.
> >>
> >> You described the desired Linux feature or behavior, not the actual
> >> hardware. The bindings are about the latter, so instead you need to
> >> rephrase the property and its description to match actual hardware
> >> capabilities/features/configuration etc.
> >
> > Is this description okay?
> > (Reused the description of retain-state-shutdown in leds-gpio.yaml)
> >
> > description:
> >   Retain the state of the PWM on shutdown. Useful in BMC systems, for
> >   example, when the BMC is rebooted while the host remains up, the fan
> >   will not stop.
>
> Nothing improved in the property. You still say what the system should
> do. This is user-space choice, not DT.

It seems better to implement it as a device attribute.