linux-kernel - Re: [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5eoqnib.wl-tiwai@suse.de>
Date: Mon, 28 Oct 2024 16:02:20 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Piyush Raj Chouhan <piyushchouhan1598@...il.com>
Cc: linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add subwoofer quirk for Infinix ZERO BOOK 13

On Sun, 27 Oct 2024 23:16:55 +0100,
Piyush Raj Chouhan wrote:
> 
> From: pc1598 <piyushchouhan1598@...il.com>

Please drop this line, otherwise it's taken as the author.
We prefer having the same address as specified in Signed-off-by tag.


thanks,

Takashi


> Infinix ZERO BOOK 13 has a 2+2 speaker system which isn't probed correctly.
> This patch adds a quirk with the proper pin connections.
> Also The mic in this laptop suffers too high gain resulting in mostly fan noise being recorded,
> This patch Also limit mic boost.
> 
> HW Probe for device; https://linux-hardware.org/?probe=a2e892c47b
> 
> Test: All 4 speaker works, Mic has low noise.
> Signed-off-by: Piyush Raj Chouhan <piyushchouhan1598@...il.com>
> ---
>  sound/pci/hda/patch_realtek.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3567b14b52b7..075935707f8a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7551,6 +7551,7 @@ enum {
>  	ALC290_FIXUP_SUBWOOFER_HSJACK,
>  	ALC269_FIXUP_THINKPAD_ACPI,
>  	ALC269_FIXUP_DMIC_THINKPAD_ACPI,
> +	ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13,
>  	ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO,
>  	ALC255_FIXUP_ACER_MIC_NO_PRESENCE,
>  	ALC255_FIXUP_ASUS_MIC_NO_PRESENCE,
> @@ -7996,6 +7997,16 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = alc269_fixup_pincfg_U7x7_headset_mic,
>  	},
> +	[ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x14, 0x90170151 }, /* use as internal speaker (LFE) */
> +			{ 0x1b, 0x90170152 }, /* use as internal speaker (back) */
> +			{ }
> +		},
> +		.chained = true,
> +		.chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> +	},
>  	[ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO] = {
>  		.type = HDA_FIXUP_PINS,
>  		.v.pins = (const struct hda_pintbl[]) {
> @@ -10989,6 +11000,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x2782, 0x0214, "VAIO VJFE-CL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> +	SND_PCI_QUIRK(0x2782, 0x0228, "Infinix ZERO BOOK 13", ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13),
>  	SND_PCI_QUIRK(0x2782, 0x0232, "CHUWI CoreBook XPro", ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO),
>  	SND_PCI_QUIRK(0x2782, 0x1707, "Vaio VJFE-ADL", ALC298_FIXUP_SPK_VOLUME),
>  	SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC),
> -- 
> 2.46.2
>