linux-kernel - Re: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2745:24: sparse: sparse: cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241028-silent-hissing-ant-aacb10@leitao>
Date: Mon, 28 Oct 2024 08:24:09 -0700
From: Breno Leitao <leitao@...ian.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: kernel test robot <lkp@...el.com>,
	Madalin Bucur <madalin.bucur@....com>,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2745:24: sparse:
 sparse: cast to restricted __be32

Hello Vladimir,

On Mon, Oct 28, 2024 at 04:10:51PM +0200, Vladimir Oltean wrote:
> Hi Breno,
> 
> On Mon, Oct 28, 2024 at 03:56:50AM -0700, Breno Leitao wrote:
> > On Sun, Oct 27, 2024 at 05:36:56PM +0800, kernel test robot wrote:
> > > Hi Breno,
> > > 
> > > First bad commit (maybe != root cause):
> > > 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   850925a8133c73c4a2453c360b2c3beb3bab67c9
> > > commit: 782fe08e9861d00ce8aca370453dd9ceb9a23d50 soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST
> > > date:   3 months ago
> > > config: arm-randconfig-r123-20241027 (https://download.01.org/0day-ci/archive/20241027/202410271721.jiVrriXD-lkp@intel.com/config)
> > > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 5886454669c3c9026f7f27eab13509dd0241f2d6)
> > > reproduce: (https://download.01.org/0day-ci/archive/20241027/202410271721.jiVrriXD-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@...el.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202410271721.jiVrriXD-lkp@intel.com/
> > > 
> > > sparse warnings: (new ones prefixed by >>)
> > > >> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2745:24: sparse: sparse: cast to restricted __be32
> > >    drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: note: in included file (through include/linux/module.h):
> > >    include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> > >    drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: note: in included file:
> > > >> include/soc/fsl/qman.h:245:16: sparse: sparse: cast to restricted __be32
> > > >> include/soc/fsl/qman.h:245:16: sparse: sparse: cast from restricted __be16
> > 
> > Thanks. The commit above "782fe08e98 ("soc: fsl: qbman: FSL_DPAA depends
> > on COMPILE_TEST") was created to detect problems like this, since it is
> > not possible to compile-test dpaa driver. 
> > 
> > Copying Madalin Bucur <madalin.bucur@....com>, who currently maintains
> > this driver.
> 
> I will handle the sparse warnings exposed by your COMPILE_TEST change,
> there is nothing actionable for you, except review if you wish.

Awesome. Thank you!

--breno