linux-kernel - Re: [PATCH] regulator: rk808: Add apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7xcp7bh.fsf@gmail.com>
Date: Mon, 28 Oct 2024 18:20:55 +0300
From: Mikhail Rudenko <mike.rudenko@...il.com>
To: linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org
Cc: Liam Girdwood <lgirdwood@...il.com>,
    Mark Brown <broonie@...nel.org>,
    Alex Bee <knaerzche@...il.com>,
    Lee Jones <lee@...nel.org>,
    Quentin Schulz <foss+kernel@...il.net>,
    Linus Walleij <linus.walleij@...aro.org>,
    Chris Zhong <zyw@...k-chips.com>,
    Zhang Qing <zhangqing@...k-chips.com>,
    Mikhail Rudenko <mike.rudenko@...il.com>
Subject: Re: [PATCH] regulator: rk808: Add apply_bit for BUCK3 on RK809

Gentle ping.

Also Cc more potential reviewers.

On 2024-10-17 at 21:37 +03, Mikhail Rudenko <mike.rudenko@...il.com> wrote:

> Currently, RK809's BUCK3 regulator is modelled in the driver as a
> configurable regulator with 0.5-2.4V voltage range. But the voltage
> setting is not actually applied, because when bit 6 of
> PMIC_POWER_CONFIG register is set to 0 (default), BUCK3 output voltage
> is determined by the external feedback resistor. Fix this, by setting
> bit 6 when voltage selection is set. Existing users which do not
> specify voltage constraints in their device trees will not be affected
> by this change, since no voltage setting is applied in those cases,
> and bit 6 is not enabled.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@...il.com>
> ---
>  drivers/regulator/rk808-regulator.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
> index 14b60abd6afc..01a8d0487918 100644
> --- a/drivers/regulator/rk808-regulator.c
> +++ b/drivers/regulator/rk808-regulator.c
> @@ -1379,6 +1379,8 @@ static const struct regulator_desc rk809_reg[] = {
>  		.n_linear_ranges = ARRAY_SIZE(rk817_buck1_voltage_ranges),
>  		.vsel_reg = RK817_BUCK3_ON_VSEL_REG,
>  		.vsel_mask = RK817_BUCK_VSEL_MASK,
> +		.apply_reg = RK817_POWER_CONFIG,
> +		.apply_bit = RK817_BUCK3_FB_RES_INTER,
>  		.enable_reg = RK817_POWER_EN_REG(0),
>  		.enable_mask = ENABLE_MASK(RK817_ID_DCDC3),
>  		.enable_val = ENABLE_MASK(RK817_ID_DCDC3),
>
> ---
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> change-id: 20241017-rk809-dcdc3-388632b4da03
>

--
Best regards,
Mikhail Rudenko