linux-kernel - Re: [PATCH v3 0/2] iommu/iova: Make the rcache depot properly flexible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zx_N1xVHFskgx-KX@arm.com>
Date: Mon, 28 Oct 2024 17:45:59 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: Ido Schimmel <idosch@...sch.org>
Cc: Robin Murphy <robin.murphy@....com>, joro@...tes.org, will@...nel.org,
	iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
	zhangzekun11@...wei.com, john.g.garry@...cle.com,
	dheerajkumar.srivastava@....com, jsnitsel@...hat.com
Subject: Re: [PATCH v3 0/2] iommu/iova: Make the rcache depot properly
 flexible

On Mon, Oct 28, 2024 at 10:04:10AM +0200, Ido Schimmel wrote:
> On Mon, Jan 15, 2024 at 09:17:04AM +0200, Ido Schimmel wrote:
> > On Fri, Jan 12, 2024 at 05:31:15PM +0200, Ido Schimmel wrote:
> > > On Thu, Jan 11, 2024 at 10:13:01AM +0000, Catalin Marinas wrote:
> > > > On Thu, Jan 11, 2024 at 10:20:27AM +0200, Ido Schimmel wrote:
> > > > > On Wed, Jan 10, 2024 at 05:58:15PM +0000, Catalin Marinas wrote:
> > > > > > Transient false positives are possible, especially as the code doesn't
> > > > > > use a double-linked list (for the latter, kmemleak does checksumming and
> > > > > > detects the prev/next change, defers the reporting until the object
> > > > > > becomes stable). That said, if a new scan is forced (echo scan >
> > > > > > /sys/kernel/debug/kmemleak), are the same objects still listed as leaks?
> > > > > > If yes, they may not be transient.
> > > > > 
> > > > > We are doing "scan" and "clear" after each test. I will disable the
> > > > > "clear" and see if the leaks persist.
> > > > 
> > > > If it is indeed a false positive
> > > 
> > > Looks like the leaks are transient. After removing the "clear" step the
> > > leaks do not seem to persist.
> > > 
> > > > you can try the patch below (I haven't given it any run-time test,
> > > > only compiled):
> > > 
> > > Will try and let you know next week.
> > 
> > Looks good. Feel free to add:
> > 
> > Tested-by: Ido Schimmel <idosch@...dia.com>
> 
> Catalin, we have been using this patch since you posted it and haven't
> seen any issues. Can please submit it upstream?

Oh, I completely forgot about it. I'll try to do it this week. Thanks
for the reminder.

-- 
Catalin