linux-kernel - Re: [PATCH] kdb: Fix breakpoint enable to be silent if already enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XP3WueSj9reLqsDm3-i3K0LMX7SJcf_Z=8E=3rD7E81g@mail.gmail.com>
Date: Mon, 28 Oct 2024 11:38:00 -0700
From: Doug Anderson <dianders@...omium.org>
To: Nir Lichtman <nir@...htman.org>
Cc: jason.wessel@...driver.com, daniel.thompson@...aro.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kdb: Fix breakpoint enable to be silent if already enabled

Hi,

On Sun, Oct 27, 2024 at 1:47 PM Nir Lichtman <nir@...htman.org> wrote:
>
> Fix the breakpoint enable command (be) to a logic that is inline with the
> breakpoint disable command (bd) in which if the breakpoint is already in
> an enabled state, do not print the message of enabled again to the user.
>
> Also a small nit fix of the new line in a separate print.
>
> Signed-off-by: Nir Lichtman <nir@...htman.org>
>
> ---
>  kernel/debug/kdb/kdb_bp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

I don't ever use these commands (if I'm setting breakpoints them I'm
using kgdb, not kdb), but this seems OK to me in general. I'm a little
curious why you don't also make the "breakpoint clear" command
consistent.

-Doug