linux-kernel - Re: [PATCH] alloc_tag: hide execmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpGDxLJQosX__Sbd9cRXj=ykG3TMRyvKES6JF34oxY6TzQ@mail.gmail.com>
Date: Mon, 28 Oct 2024 11:51:20 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Mike Rapoport <rppt@...nel.org>
Cc: Arnd Bergmann <arnd@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	Pasha Tatashin <pasha.tatashin@...een.com>, Arnd Bergmann <arnd@...db.de>, 
	Luis Chamberlain <mcgrof@...nel.org>, Song Liu <song@...nel.org>, 
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alloc_tag: hide execmem_vmap() on !MMU

On Mon, Oct 28, 2024 at 7:43 AM Mike Rapoport <rppt@...nel.org> wrote:
>
> On Mon, Oct 28, 2024 at 02:18:09PM +0000, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > The newly added function fails to link on nommu kernels, but is also
> > not needed there:
> >
> > ld.lld-20: error: undefined symbol: __get_vm_area_node
> > >>> referenced by execmem.c
> > >>>               mm/execmem.o:(execmem_vmap) in archive vmlinux.a
> > >>> referenced by execmem.c
> > >>>               mm/execmem.o:(execmem_vmap) in archive vmlinux.a
> >
> > Fixes: 57bc3834fb6f ("alloc_tag: populate memory for module tags as needed")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  mm/execmem.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/mm/execmem.c b/mm/execmem.c
> > index 5c0f9f2d6f83..b04cfece7356 100644
> > --- a/mm/execmem.c
> > +++ b/mm/execmem.c
> > @@ -368,6 +368,7 @@ void execmem_free(void *ptr)
> >               vfree(ptr);
> >  }
> >
> > +#ifdef CONFIG_MMU
> >  struct vm_struct *execmem_vmap(size_t size)
> >  {
> >       struct execmem_range *range = &execmem_info->ranges[EXECMEM_MODULE_DATA];
> > @@ -383,6 +384,7 @@ struct vm_struct *execmem_vmap(size_t size)
> >
> >       return area;
> >  }
> > +#endif
>
> Nit: there is already #ifdef CONFIG_MMU block in execmem.c, better to move
> execmem_vmap() there
>
> Other than that
>
> Acked-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

Thanks for the fix but execmem_vmap() is used if
CONFIG_MEM_ALLOC_PROFILING=y. Please give me an hour to post a fix
dealing with that.

>
> >  void *execmem_update_copy(void *dst, const void *src, size_t size)
> >  {
> > --
> > 2.39.5
> >
>
> --
> Sincerely yours,
> Mike.